git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/3] Add test for commit --dry-run --short.

From
SSStephen & Linda Smith <ischis2@cox.net>
Date
Sep 2, 2018, 05:17 UTC
Message-ID
<3033920.bsSLEtmIa1@thunderbird>
In-Reply-To
<20180901235256.4260-3-ischis2@cox.net>
On Saturday, September 1, 2018 7:18:34 PM MST Eric Sunshine wrote:
Show 10 quoted lines
> > diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh
> > @@ -682,4 +682,12 @@ test_expect_success '--dry-run with conflicts fixed
> > from a merge' ' +test_expect_failure '--dry-run --short' '
> > +       # setup two branches with conflicting information
> > +       # in the same file, resolve the conflict
> 
> What is this comment all about? It doesn't seem to have any relation
> to what the test itself is actually doing. (I see that it was copied
> from an earlier test in this script, but that doesn't help me
> understand what it is trying to say.)
Agreed.

I saw your other email about not being worth a re-roll, but I've made the change locally in case Junio wants me to do so. 

Additionally if there are other comments I can wrap them into a single set.
Previous: Eric SunshineNext: Stephen P. Smith
Message 6 of 7 in “wt-status.c: commitable flag”
  1. 0/3 wt-status.c: commitable flagStephen P. Smith, Sep 1, 2018
  2. 1/3 wt-status.c: Move has_unmerged earlier in the file.Stephen P. Smith, Sep 1, 2018
  3. 2/3 Add test for commit --dry-run --short.Stephen P. Smith, Sep 1, 2018
  4. Eric SunshineSep 2, 2018
  5. Eric SunshineSep 2, 2018
  6. Stephen & Linda SmithSep 2, 2018
  7. 3/3 wt-status.c: Set the commitable flag in the collect phase.Stephen P. Smith, Sep 1, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.