Re: git 2.16.0 segfaults on clone of specific repo

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 20, 2018, 00:23 UTC
Message-ID: <CAPig+cSRN1zHc=zsO1Y_aQ_eO+sbsd0cq5iZ9hYz3ruK_E-0Dw@mail.gmail.com>
In-Reply-To: <20180119172549.GK1427@zaya.teonanacatl.net>

On Fri, Jan 19, 2018 at 12:25 PM, Todd Zullinger <tmz@pobox.com> wrote:

Show 10 quoted lines

> Eric Sunshine wrote:
>> Nice detective work. This particular manifestation is caught by the
>> following test which fails without brian's patch on MacOS (and
>> presumably Windows) and succeeds with it. On Linux and BSD, it will of
>> course succeed always, so I'm not sure how much practical value it
>> has.
>
> The CASE_INSENSITIVE_FS prereq could be used to avoid
> running the test on systems where it won't provide much
> value, couldn't it?

As mentioned in [1], my original questioning of the practical value of the test was tied to the belief that the full test suite is probably rarely run on MacOS, and it wasn't until I pressed "Send" that it hit me that it would manifest on Windows as well, and that Dscho does test on Windows regularly. Therefore, the test could have value.

At any rate, the test potentially could catch some sort of future regression even on case-sensitive filesystems, therefore, it would be better not to hide it behind CASE_INSENSITIVE_FS.

[1]: https://public-inbox.org/git/CAPig+cQmWqQWQrRQHHn=3hn6UFzJxT=9d5kKnJht_dt8sCgwkQ@mail.gmail.com/