Re: git 2.16.0 segfaults on clone of specific repo

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 20, 2018, 00:15 UTC
Message-ID: <CAPig+cQmWqQWQrRQHHn=3hn6UFzJxT=9d5kKnJht_dt8sCgwkQ@mail.gmail.com>
In-Reply-To: <20180119223130.GC222163@genre.crustytoothpaste.net>

On Fri, Jan 19, 2018 at 5:31 PM, brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 12 quoted lines

> On Fri, Jan 19, 2018 at 02:40:02AM -0500, Eric Sunshine wrote:
>> Nice detective work. This particular manifestation is caught by the
>> following test which fails without brian's patch on MacOS (and
>> presumably Windows) and succeeds with it. On Linux and BSD, it will of
>> course succeed always, so I'm not sure how much practical value it
>> has.
>
> I'd argue that it's a worthwhile test to have, since it will fail on
> those systems where it's going to be a problem.  Furthermore, people do
> run the tests (as does Travis) on case-insensitive file systems during
> the development cycle, so if we break something in the future, someone
> will notice while we're still in the development cycle.

Oh, I agree. My original question of its practical value was based upon my belief that the full test suite is very rarely run on MacOS (partly because there are so few Git developers on MacOS and partly because it runs so slowly on the platform, though not nearly as slowly as on Windows). However, as soon as I hit "Send", it hit me that the problem would also manifest on Windows, and we know that Dscho runs the tests regularly on Windows, so I changed my mind. I did consider Travis but wasn't sure if it was testing on case-insensitive filesystems.

Are you planning on submitting the test as a proper patch as follow-up to [1]? I couldn't quite decide in which test script it should reside.

[1]: https://public-inbox.org/git/xmqqr2qlps7r.fsf@gitster.mtv.corp.google.com/