git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git 2.16.0 segfaults on clone of specific repo

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jan 19, 2018, 08:28 UTC
Message-ID
<CAPig+cQmCeEHZNkYSRPUTZHyRP-Tkiobx6ghSktYiT9CCBV6FA@mail.gmail.com>
In-Reply-To
<CACsJy8AOPDNTbAWzDHd+Oa5PSc1v2qdfcaq60P7X5wznM4VTug@mail.gmail.com>
On Fri, Jan 19, 2018 at 3:22 AM, Duy Nguyen <pclouds@gmail.com> wrote:
Show 22 quoted lines
> On Fri, Jan 19, 2018 at 2:40 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> On Fri, Jan 19, 2018 at 12:31:58PM +0700, Duy Nguyen wrote:
>>> On Linux, after I hacked all over the place to force ce_match_stat()
>>> to eventually call index_fd() which in turns must use one of the
>>> hashing function, I got a crash.
>>
>> Nice detective work.
>
> And not stepping back to think for a bit. I realized now that if I
> just mounted a vfat filesystem, I could have verified it much quicker.
> It does crash on linux with similar stack trace.
> [...]
>> This particular manifestation is caught by the
>> following test which fails without brian's patch on MacOS (and
>> presumably Windows) and succeeds with it. On Linux and BSD, it will of
>> course succeed always, so I'm not sure how much practical value it
>> has.
>
> There's a travis job running "on windows" (I don't what it really
> means) so it might help actually. This vim-colorschemes repository has
> shown up in git mailing list before, I think. We probably should just
> add it as part of our regression tests ;-)

And, Dscho does run the test suite on Windows regularly, so perhaps this test does have some practical value.

Previous: Duy NguyenNext: Todd Zullinger
Message 11 of 33 in “git 2.16.0 segfaults on clone of specific repo”
  1. Александр БулаевJan 18, 2018
  2. Randall S. BeckerJan 18, 2018
  3. Eric SunshineJan 19, 2018
  4. brian m. carlsonJan 19, 2018
  5. Eric SunshineJan 19, 2018
  6. Randall S. BeckerJan 19, 2018
  7. brian m. carlsonJan 19, 2018
  8. Duy NguyenJan 19, 2018
  9. Eric SunshineJan 19, 2018
  10. Duy NguyenJan 19, 2018
  11. Eric SunshineJan 19, 2018
  12. Todd ZullingerJan 19, 2018
  13. Eric SunshineJan 20, 2018
  14. brian m. carlsonJan 19, 2018
  15. Eric SunshineJan 20, 2018
  16. brian m. carlsonJan 20, 2018
  17. Eric SunshineJan 20, 2018
  18. repository: pre-initialize hash algo pointerbrian m. carlson, Jan 19, 2018
  19. Eric SunshineJan 19, 2018
  20. Junio C HamanoJan 19, 2018
  21. Eric SunshineJan 19, 2018
  22. Junio C HamanoJan 19, 2018
  23. brian m. carlsonJan 19, 2018
  24. Junio C HamanoJan 20, 2018
  25. Eric SunshineJan 20, 2018
  26. t: add clone test for files differing only in casebrian m. carlson, Jan 20, 2018
  27. Eric SunshineJan 21, 2018
  28. Junio C HamanoJan 21, 2018
  29. Eric SunshineJan 21, 2018
  30. Eric SunshineJan 21, 2018
  31. brian m. carlsonJan 21, 2018
  32. Duy NguyenJan 21, 2018
  33. Eric SunshineJan 21, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.