Re: [PATCH] repository: pre-initialize hash algo pointer

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 19, 2018, 21:48 UTC
Message-ID: <CAPig+cRX2HpUPCnuf3aiZO71KmFgBR4JE_=NBA3UuwuRxrXR2Q@mail.gmail.com>
In-Reply-To: <xmqqr2qlps7r.fsf@gitster.mtv.corp.google.com>

On Fri, Jan 19, 2018 at 2:24 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 19 quoted lines

> Eric Sunshine <sunshine@sunshineco.com> writes:
>> Now that we know (due to Duy's excellent detective work[1]) that the
>> trigger is files with names differing only in case on case-insensitive
>> filesystems, the commit message can be updated appropriately.
>
> Thanks.  Let me apply the following and do a 2.16.1, hopefully by
> the end of day or mid tomorrow at the latest.  Test to protect the
> fix can come as a separate follow-up patch.
>
> -- >8 --
> Subject: [PATCH] repository: pre-initialize hash algo pointer
> [...]
> A "git clone" of a project that has two paths that differ only in
> case suffers from this if it is run on a case insensitive platform.
> When the command attempts to check out one of these two paths after
> checking out the other one, the checkout codepath needs to see if
> the version that is already on the filesystem (which should not
> happen if the FS were case sensitive), and it needs to exercise the
> hashing code.

Thanks, the amended commit message makes the reason for the patch more concrete. There does seem to be a bit of a grammatical issue, however, which makes it difficult to parse. Namely, "already on the filesystem (...)" probably was meant to say "already on the filesystem (...) is {something}".