git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 6, 2016, 05:53 UTC
Message-ID
<CAPig+cSR6CQ6Q=TOaTgqwC0nOkB_khDLevWDPZsOwKbGrjptKQ@mail.gmail.com>
In-Reply-To
<CA+EOSBmL8oHo_wWUzyBq=4Z7fFoFj5Gnf7UveOyiNMS3yhH8Uw@mail.gmail.com>
On Tue, Apr 5, 2016 at 6:21 AM, Elia Pinto <gitter.spiros@gmail.com> wrote:
Show 7 quoted lines
> 2016-04-01 22:25 GMT+02:00 Eric Sunshine <sunshine@sunshineco.com>:
>> In addition to review comments by others, why are the new curl_dump()
>> and curl_trace() functions duplicated in both patches rather than
>> factored out to a shared implementation?
>
> It's right. Do you think i can use some existing file or should I
> create a new object file ?

Peff or Junio would be more qualified to answer, but perhaps the shared implementation could go in http.c?

Previous: Elia PintoNext: Jeff King
Message 13 of 14 in “imap-send.c: implements the GIT_CURL_DEBUG environment variable”
  1. 1/2 imap-send.c: implements the GIT_CURL_DEBUG environment variableElia Pinto, Apr 1, 2016
  2. 2/2 http.c: implements the GIT_CURL_DEBUG environment variableElia Pinto, Apr 1, 2016
  3. Ramsay JonesApr 1, 2016
  4. Elia PintoApr 4, 2016
  5. Torsten BögershausenApr 1, 2016
  6. Ramsay JonesApr 1, 2016
  7. Elia PintoApr 4, 2016
  8. Junio C HamanoApr 1, 2016
  9. Elia PintoApr 4, 2016
  10. Junio C HamanoApr 4, 2016
  11. Eric SunshineApr 1, 2016
  12. Elia PintoApr 5, 2016
  13. Eric SunshineApr 6, 2016
  14. Jeff KingApr 6, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.