From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 06 Apr 2016 05:53:35 GMT
Subject: Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable
Message-ID: <CAPig+cSR6CQ6Q=TOaTgqwC0nOkB_khDLevWDPZsOwKbGrjptKQ@mail.gmail.com>
In-Reply-To: <CA+EOSBmL8oHo_wWUzyBq=4Z7fFoFj5Gnf7UveOyiNMS3yhH8Uw@mail.gmail.com>

On Tue, Apr 5, 2016 at 6:21 AM, Elia Pinto <gitter.spiros@gmail.com> wrote:
> 2016-04-01 22:25 GMT+02:00 Eric Sunshine <sunshine@sunshineco.com>:
>> In addition to review comments by others, why are the new curl_dump()
>> and curl_trace() functions duplicated in both patches rather than
>> factored out to a shared implementation?
>
> It's right. Do you think i can use some existing file or should I
> create a new object file ?

Peff or Junio would be more qualified to answer, but perhaps the
shared implementation could go in http.c?