Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 1, 2016, 15:35 UTC
- Message-ID
- <xmqqtwjljq97.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1459507482-36678-1-git-send-email-gitter.spiros@gmail.com>
Elia Pinto <gitter.spiros@gmail.com> writes:
Show 5 quoted lines
> Implements the GIT_CURL_DEBUG environment variable to allow a greater > degree of detail of GIT_CURL_VERBOSE, in particular the complete > transport header and all the data payload exchanged. > It might be useful if a particular situation could require a more > thorough debugging analysis.
My impression is that using GIT_TRACE_* is the more mainstream trend, and it may be beneficial to work any new debugging aid like this one to fit within that mechanism.
I am not saying new GIT_*_DEBUG is wrong. I just wanted to make sure you have considered doing this as a new trace in GIT_TRACE_* family and rejected that apporach with a very good reason, in which case that rationale deserves to be in the log message.