git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

From
Torsten Bögershausen <tboegi@web.de>
Date
Apr 1, 2016, 11:44 UTC
Message-ID
<56FE5F1C.2040103@web.de>
In-Reply-To
<1459507482-36678-1-git-send-email-gitter.spiros@gmail.com>
On 01.04.16 12:44, Elia Pinto wrote:
Show 23 quoted lines
> Implements the GIT_CURL_DEBUG environment variable to allow a greater
> degree of detail of GIT_CURL_VERBOSE, in particular the complete
> transport header and all the data payload exchanged.
> It might be useful if a particular situation could require a more
> thorough debugging analysis.
> 
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> ---
>  imap-send.c | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 97 insertions(+), 2 deletions(-)
> 
> diff --git a/imap-send.c b/imap-send.c
> index 4d3b773..cf79e7f 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1395,6 +1395,96 @@ static int append_msgs_to_imap(struct imap_server_conf *server,
>  }
>  
>  #ifdef USE_CURL_FOR_IMAP_SEND
> +
> +static
> +void curl_dump(const char *text,
> +	  FILE * stream, unsigned char *ptr, size_t size, char nohex)
Style: FILE *stream
> +{
> +	size_t i;
> +	size_t c;

c is typically a character. 'j' may be better, unless you find a longer, and more descriptive name.

Show 25 quoted lines
> +
> +	unsigned int width = 0x10;
> +
> +	if (nohex)
> +		/* without the hex output, we can fit more on screen */
> +		width = 0x40;
> +
> +	fprintf(stream, "%s, %10.10ld bytes (0x%8.8lx)\n",
> +		text, (long)size, (long)size);
> +
> +	for (i = 0; i < size; i += width) {
> +
> +		fprintf(stream, "%4.4lx: ", (long)i);
> +
> +		if (!nohex) {
> +			/* hex not disabled, show it */
> +			for (c = 0; c < width; c++)
> +				if (i + c < size)
> +					fprintf(stream, "%02x ", ptr[i + c]);
> +				else
> +					fputs("   ", stream);
> +		}
> +
> +		for (c = 0; (c < width) && (i + c < size); c++) {
> +			/* check for 0D0A; if found, skip past and start a new line of output */

Should we write '\r' and '\n' instead for hex codes ? and CRLF instead of 0D0A ? (Yes the RFC use hexcodes, but we write readable C-code)

Previous: Elia PintoNext: Ramsay Jones
Message 5 of 14 in “imap-send.c: implements the GIT_CURL_DEBUG environment variable”
  1. 1/2 imap-send.c: implements the GIT_CURL_DEBUG environment variableElia Pinto, Apr 1, 2016
  2. 2/2 http.c: implements the GIT_CURL_DEBUG environment variableElia Pinto, Apr 1, 2016
  3. Ramsay JonesApr 1, 2016
  4. Elia PintoApr 4, 2016
  5. Torsten BögershausenApr 1, 2016
  6. Ramsay JonesApr 1, 2016
  7. Elia PintoApr 4, 2016
  8. Junio C HamanoApr 1, 2016
  9. Elia PintoApr 4, 2016
  10. Junio C HamanoApr 4, 2016
  11. Eric SunshineApr 1, 2016
  12. Elia PintoApr 5, 2016
  13. Eric SunshineApr 6, 2016
  14. Jeff KingApr 6, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.