git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff-tree: read the index so attribute checks work in bare repositories

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Dec 6, 2017, 22:07 UTC
Message-ID
<CAPig+cSNwPJkVNNbnp-rh-jXgwrEXhvzVHZoQM6wQMQNjn5n5Q@mail.gmail.com>
In-Reply-To
<20171206220055.GB118027@google.com>
On Wed, Dec 6, 2017 at 5:00 PM, Brandon Williams <bmwill@google.com> wrote:
Show 16 quoted lines
> On 12/05, Eric Sunshine wrote:
>> 557a5998d (submodule: remove gitmodules_config, 2017-08-03) touched a
>> fair number of built-in commands. It's not clear from the current
>> patch's commit message if diff-tree is the only command which
>> regressed. Is it? Or are other commands also likely to have regressed?
>> Perhaps the commit message could say something about this. For
>> instance: "All other commands touched by 557a5998d have been audited
>> and were found to be regression-free" or "Other commands may regress
>> in the same way, but we will take a wait-and-see attitude and fix them
>> as needed because <fill-in-reason>".
>
> I don't know if any other commands have regressed.  This was such an odd
> regression that I think it would be difficult to say for certain that
> there couldn't be others.  I did go through the affected builtins to see
> if I could find anything.  I came up empty handed so I think we should
> be ok.

Thanks for the response. It would be nice to have this explained in the commit message so that future readers don't have to wonder about it.

Previous: Brandon WilliamsNext: Brandon Williams
Message 14 of 15 in “gitattributes not read for diff-tree anymore in 2.15?”
  1. Ben BoeckelDec 4, 2017
  2. Brandon WilliamsDec 4, 2017
  3. Ben BoeckelDec 5, 2017
  4. Brandon WilliamsDec 5, 2017
  5. Ben BoeckelDec 5, 2017
  6. diff-tree: read the index so attribute checks work in bare repositoriesBrandon Williams, Dec 5, 2017
  7. Ben BoeckelDec 5, 2017
  8. Brandon WilliamsDec 5, 2017
  9. Junio C HamanoDec 5, 2017
  10. Stefan BellerDec 5, 2017
  11. Brandon WilliamsDec 6, 2017
  12. Eric SunshineDec 5, 2017
  13. Brandon WilliamsDec 6, 2017
  14. Eric SunshineDec 6, 2017
  15. diff-tree: read the index so attribute checks work in bare repositoriesBrandon Williams, Dec 6, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.