git/list[1] front-page[2] threads[3] people[4] search[5] about
 

gitattributes not read for diff-tree anymore in 2.15?

From
BBBen Boeckel <ben.boeckel@kitware.com>
Date
Dec 4, 2017, 21:22 UTC
Message-ID
<20171204212255.GA19059@megas.kitware.com>
Hi,
I've bisected a failure in our test suite to this commit:
    commit 557a5998df19faf8641acfc5b6b1c3c2ba64dca9 (HEAD, refs/bisect/bad)
    Author: Brandon Williams <bmwill@google.com>
    Date:   Thu Aug 3 11:20:00 2017 -0700
        submodule: remove gitmodules_config
        Now that the submodule-config subsystem can lazily read the gitmodules
        file we no longer need to explicitly pre-read the gitmodules by calling
        'gitmodules_config()' so let's remove it.
        Signed-off-by: Brandon Williams <bmwill@google.com>
        Signed-off-by: Junio C Hamano <gitster@pobox.com>
Which is tags/v2.15.0-rc0~120^2.
Our test suite is in a Rust project here:
    https://gitlab.kitware.com/utils/rust-git-checks
and the failing test(s) can be run using:
    cargo test whitespace_all_ignored

The test checks that when `.gitattributes` says that whitespace errors should be ignored, they aren't reported as errors. My guess is that not reading the gitmodules configuration also skips reading attributes files. Is this reasoning correct?

Thanks,
--Ben
Next: Brandon Williams
Message 1 of 15 in “gitattributes not read for diff-tree anymore in 2.15?”
  1. Ben BoeckelDec 4, 2017
  2. Brandon WilliamsDec 4, 2017
  3. Ben BoeckelDec 5, 2017
  4. Brandon WilliamsDec 5, 2017
  5. Ben BoeckelDec 5, 2017
  6. diff-tree: read the index so attribute checks work in bare repositoriesBrandon Williams, Dec 5, 2017
  7. Ben BoeckelDec 5, 2017
  8. Brandon WilliamsDec 5, 2017
  9. Junio C HamanoDec 5, 2017
  10. Stefan BellerDec 5, 2017
  11. Brandon WilliamsDec 6, 2017
  12. Eric SunshineDec 5, 2017
  13. Brandon WilliamsDec 6, 2017
  14. Eric SunshineDec 6, 2017
  15. diff-tree: read the index so attribute checks work in bare repositoriesBrandon Williams, Dec 6, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.