git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: gitattributes not read for diff-tree anymore in 2.15?

From
BBBen Boeckel <ben.boeckel@kitware.com>
Date
Dec 5, 2017, 15:42 UTC
Message-ID
<20171205154244.GA16581@megas.kitware.com>
In-Reply-To
<20171204230355.GA52452@google.com>
On Mon, Dec 04, 2017 at 15:03:55 -0800, Brandon Williams wrote:
> Reading the attributes files should be done regardless if the gitmodules
> file is read.  The gitmodules file should only come into play if you are
> dealing with submodules.

Yeah, it doesn't seem to make sense why this commit breaks us, but there it is *shrug*.

> Do you mind providing a reproduction recipe with expected outcome vs
> actual outcome and I can take a closer look.

I'll work on one. It isn't as simple as I thought it was :) . The setup we do before running the checks is apparently involved as running it from the command line is not exhibiting the difference.

--Ben
Previous: Brandon WilliamsNext: Brandon Williams
Message 3 of 15 in “gitattributes not read for diff-tree anymore in 2.15?”
  1. Ben BoeckelDec 4, 2017
  2. Brandon WilliamsDec 4, 2017
  3. Ben BoeckelDec 5, 2017
  4. Brandon WilliamsDec 5, 2017
  5. Ben BoeckelDec 5, 2017
  6. diff-tree: read the index so attribute checks work in bare repositoriesBrandon Williams, Dec 5, 2017
  7. Ben BoeckelDec 5, 2017
  8. Brandon WilliamsDec 5, 2017
  9. Junio C HamanoDec 5, 2017
  10. Stefan BellerDec 5, 2017
  11. Brandon WilliamsDec 6, 2017
  12. Eric SunshineDec 5, 2017
  13. Brandon WilliamsDec 6, 2017
  14. Eric SunshineDec 6, 2017
  15. diff-tree: read the index so attribute checks work in bare repositoriesBrandon Williams, Dec 6, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.