Re: gitattributes not read for diff-tree anymore in 2.15?

From: Brandon Williams <bmwill@google.com>
Date: Dec 4, 2017, 23:03 UTC
Message-ID: <20171204230355.GA52452@google.com>
In-Reply-To: <20171204212255.GA19059@megas.kitware.com>

On 12/04, Ben Boeckel wrote:

Show 35 quoted lines

> Hi,
> 
> I've bisected a failure in our test suite to this commit:
> 
>     commit 557a5998df19faf8641acfc5b6b1c3c2ba64dca9 (HEAD, refs/bisect/bad)
>     Author: Brandon Williams <bmwill@google.com>
>     Date:   Thu Aug 3 11:20:00 2017 -0700
> 
>         submodule: remove gitmodules_config
> 
>         Now that the submodule-config subsystem can lazily read the gitmodules
>         file we no longer need to explicitly pre-read the gitmodules by calling
>         'gitmodules_config()' so let's remove it.
> 
>         Signed-off-by: Brandon Williams <bmwill@google.com>
>         Signed-off-by: Junio C Hamano <gitster@pobox.com>
> 
> Which is tags/v2.15.0-rc0~120^2.
> 
> Our test suite is in a Rust project here:
> 
>     https://gitlab.kitware.com/utils/rust-git-checks
> 
> and the failing test(s) can be run using:
> 
>     cargo test whitespace_all_ignored
> 
> The test checks that when `.gitattributes` says that whitespace errors
> should be ignored, they aren't reported as errors. My guess is that not
> reading the gitmodules configuration also skips reading attributes
> files. Is this reasoning correct?
> 
> Thanks,
> 
> --Ben

Reading the attributes files should be done regardless if the gitmodules file is read. The gitmodules file should only come into play if you are dealing with submodules.

Do you mind providing a reproduction recipe with expected outcome vs actual outcome and I can take a closer look.

-- 
Brandon Williams