git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 06/15] submodule--helper: die on config error when cloning module

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Feb 2, 2016, 18:45 UTC
Message-ID
<CAPig+cSLoXGHFXm96dpfjmkZkpXOFezEFZek-Jry85XkCwOsWA@mail.gmail.com>
In-Reply-To
<1454413916-31984-7-git-send-email-ps@pks.im>
On Tue, Feb 2, 2016 at 6:51 AM, Patrick Steinhardt <ps@pks.im> wrote:
> When setting the 'core.worktree' option for a newly cloned
> submodule we ignore the return value of `git_config_set_in_file`.
> As this leaves the submodule in an inconsistent state, we instaed
> we want to inform the user that something has gone wrong by
s/instaed/instead/

Also, there are too many "we"s, so dropping one would be a good idea: either "we instead" or "instead we".

> printing an error and aborting the program.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 11 of 26 in “config: make git_config_set die on failure”
  1. 00/15 config: make git_config_set die on failurePatrick Steinhardt, Feb 2, 2016
  2. 01/15 config: introduce set_or_die wrappersPatrick Steinhardt, Feb 2, 2016
  3. 02/15 branch: die on error in setting up tracking branchPatrick Steinhardt, Feb 2, 2016
  4. Junio C HamanoFeb 2, 2016
  5. Patrick SteinhardtFeb 8, 2016
  6. Patrick SteinhardtFeb 8, 2016
  7. 03/15 branch: die on config error when unsetting upstreamPatrick Steinhardt, Feb 2, 2016
  8. 04/15 branch: die on config error when editing branch descriptionPatrick Steinhardt, Feb 2, 2016
  9. 05/15 submodule: die on config error when linking modulesPatrick Steinhardt, Feb 2, 2016
  10. 06/15 submodule--helper: die on config error when cloning modulePatrick Steinhardt, Feb 2, 2016
  11. Eric SunshineFeb 2, 2016
  12. Patrick SteinhardtFeb 8, 2016
  13. 07/15 remote: die on config error when setting URLPatrick Steinhardt, Feb 2, 2016
  14. Patrick SteinhardtFeb 2, 2016
  15. 08/15 remote: die on config error when setting/adding branchesPatrick Steinhardt, Feb 2, 2016
  16. 09/15 remote: die on config error when manipulating remotesPatrick Steinhardt, Feb 2, 2016
  17. 10/15 clone: die on config error in cmd_clonePatrick Steinhardt, Feb 2, 2016
  18. Junio C HamanoFeb 2, 2016
  19. 11/15 init-db: die on config errors when initializing empty repoPatrick Steinhardt, Feb 2, 2016
  20. 12/15 sequencer: die on config error when saving replay optsPatrick Steinhardt, Feb 2, 2016
  21. 13/15 compat: die when unable to set core.precomposeunicodePatrick Steinhardt, Feb 2, 2016
  22. 14/15 config: rename git_config_set to git_config_set_gentlyPatrick Steinhardt, Feb 2, 2016
  23. 15/15 config: rename git_config_set_or_die to git_config_setPatrick Steinhardt, Feb 2, 2016
  24. Stefan BellerFeb 2, 2016
  25. Junio C HamanoFeb 2, 2016
  26. Patrick SteinhardtFeb 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.