Re: [PATCH v4 06/15] submodule--helper: die on config error when cloning module

From: Patrick Steinhardt <ps@pks.im>
Date: Feb 8, 2016, 14:05 UTC
Message-ID: <20160208140551.GC697@pks-xps>
In-Reply-To: <CAPig+cSLoXGHFXm96dpfjmkZkpXOFezEFZek-Jry85XkCwOsWA@mail.gmail.com>

On Tue, Feb 02, 2016 at 01:45:50PM -0500, Eric Sunshine wrote:

Show 14 quoted lines

> On Tue, Feb 2, 2016 at 6:51 AM, Patrick Steinhardt <ps@pks.im> wrote:
> > When setting the 'core.worktree' option for a newly cloned
> > submodule we ignore the return value of `git_config_set_in_file`.
> > As this leaves the submodule in an inconsistent state, we instaed
> > we want to inform the user that something has gone wrong by
> 
> s/instaed/instead/
> 
> Also, there are too many "we"s, so dropping one would be a good idea:
> either "we instead" or "instead we".
> 
> > printing an error and aborting the program.
> >
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>

Thanks, fixed now.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.