From: Eric Sunshine Date: Tue, 02 Feb 2016 18:45:50 GMT Subject: Re: [PATCH v4 06/15] submodule--helper: die on config error when cloning module Message-ID: In-Reply-To: <1454413916-31984-7-git-send-email-ps@pks.im> On Tue, Feb 2, 2016 at 6:51 AM, Patrick Steinhardt wrote: > When setting the 'core.worktree' option for a newly cloned > submodule we ignore the return value of `git_config_set_in_file`. > As this leaves the submodule in an inconsistent state, we instaed > we want to inform the user that something has gone wrong by s/instaed/instead/ Also, there are too many "we"s, so dropping one would be a good idea: either "we instead" or "instead we". > printing an error and aborting the program. > > Signed-off-by: Patrick Steinhardt