git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] worktree: accept multiple paths

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Mar 29, 2022, 18:36 UTC
Message-ID
<CAPig+cSJPoj8jk_JHmpc4=3bupZ98dKmDi+POZQXZxJR+CjhKA@mail.gmail.com>
In-Reply-To
<xmqq1qykycgc.fsf@gitster.g>
On Tue, Mar 29, 2022 at 12:02 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> Desmond Preston <despreston@gmail.com> writes:
> >> The fact that this line was introduced in [PATCH 1/2] and then
> >> needed to immediately be corrected with this patch means the
> >> previous patch was suboptimal and this patch is "oops, the last one
> >> was bad and here is a band-aid fix-up".
> >>
> >> Let's not do so.  Instead, you are encouraged to pretend to be a
> >> more perfect developer who does not make unnecessary mistake ;-)
>
> FYI, I've queued [1/2] with the fix-up in [2/2] squashed in.
>
>         N_("git worktree remove [<options>] <worktree>"),
> +       N_("git worktree repair [<path>...]"),
>         N_("git worktree unlock <path>"),

This version looks good to me and addresses my review comments[*], and still has my Acked-by: for what it's worth.

Thanks for putting the finishing touches on this.
[*]: https://lore.kernel.org/git/3f823608-adf4-f717-13d8-8da6f89a9506@sunshineco.com/
Previous: Junio C HamanoNext: Des Preston via GitGitGadget
Message 8 of 9 in “worktree: include repair cmd in usage”
  1. worktree: include repair cmd in usageDes Preston via GitGitGadget, Mar 25, 2022
  2. Eric SunshineMar 25, 2022
  3. 0/2 worktree: include repair cmd in usageDes Preston via GitGitGadget, Mar 28, 2022
  4. 2/2 worktree: accept multiple pathsDes Preston via GitGitGadget, Mar 28, 2022
  5. Junio C HamanoMar 29, 2022
  6. Desmond PrestonMar 29, 2022
  7. Junio C HamanoMar 29, 2022
  8. Eric SunshineMar 29, 2022
  9. 1/2 worktree: include repair cmd in usageDes Preston via GitGitGadget, Mar 28, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.