From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 29 Mar 2022 18:36:52 GMT
Subject: Re: [PATCH v2 2/2] worktree: accept multiple paths
Message-ID: <CAPig+cSJPoj8jk_JHmpc4=3bupZ98dKmDi+POZQXZxJR+CjhKA@mail.gmail.com>
In-Reply-To: <xmqq1qykycgc.fsf@gitster.g>

On Tue, Mar 29, 2022 at 12:02 PM Junio C Hamano <gitster@pobox.com> wrote:
> Desmond Preston <despreston@gmail.com> writes:
> >> The fact that this line was introduced in [PATCH 1/2] and then
> >> needed to immediately be corrected with this patch means the
> >> previous patch was suboptimal and this patch is "oops, the last one
> >> was bad and here is a band-aid fix-up".
> >>
> >> Let's not do so.  Instead, you are encouraged to pretend to be a
> >> more perfect developer who does not make unnecessary mistake ;-)
>
> FYI, I've queued [1/2] with the fix-up in [2/2] squashed in.
>
>         N_("git worktree remove [<options>] <worktree>"),
> +       N_("git worktree repair [<path>...]"),
>         N_("git worktree unlock <path>"),

This version looks good to me and addresses my review comments[*], and
still has my Acked-by: for what it's worth.

Thanks for putting the finishing touches on this.

[*]: https://lore.kernel.org/git/3f823608-adf4-f717-13d8-8da6f89a9506@sunshineco.com/