Re: [PATCH v2 2/2] worktree: accept multiple paths
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 29, 2022, 01:00 UTC
- Message-ID
- <xmqq35j1zi7j.fsf@gitster.g>
- In-Reply-To
- <1df005a4ef1e387c7f7f5486a7a8800b9cd204a8.1648500426.git.gitgitgadget@gmail.com>
"Des Preston via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 20 quoted lines
> From: Des Preston <despreston@gmail.com>
>
> Update the worktree usage to show that the repair command can take
> multiple paths.
>
> Signed-off-by: Des Preston <despreston@gmail.com>
> ---
> builtin/worktree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/worktree.c b/builtin/worktree.c
> index 8682ff4c417..498975c1fd9 100644
> --- a/builtin/worktree.c
> +++ b/builtin/worktree.c
> @@ -22,7 +22,7 @@ static const char * const worktree_usage[] = {
> N_("git worktree move <worktree> <new-path>"),
> N_("git worktree prune [<options>]"),
> N_("git worktree remove [<options>] <worktree>"),
> - N_("git worktree repair [<path>]"),
> + N_("git worktree repair [<path>...]"),The fact that this line was introduced in [PATCH 1/2] and then needed to immediately be corrected with this patch means the previous patch was suboptimal and this patch is "oops, the last one was bad and here is a band-aid fix-up".
Let's not do so. Instead, you are encouraged to pretend to be a more perfect developer who does not make unnecessary mistake ;-)