git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] worktree: accept multiple paths

From
DPDesmond Preston <despreston@gmail.com>
Date
Mar 29, 2022, 03:00 UTC
Message-ID
<48242777-6442-4A4D-BE76-1B9EF2F7175B@gmail.com>
In-Reply-To
<xmqq35j1zi7j.fsf@gitster.g>
k. 
Show 33 quoted lines
> On Mar 28, 2022, at 9:00 PM, Junio C Hamano <gitster@pobox.com> wrote:
> 
> "Des Preston via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Des Preston <despreston@gmail.com>
>> 
>> Update the worktree usage to show that the repair command can take
>> multiple paths.
>> 
>> Signed-off-by: Des Preston <despreston@gmail.com>
>> ---
>> builtin/worktree.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/builtin/worktree.c b/builtin/worktree.c
>> index 8682ff4c417..498975c1fd9 100644
>> --- a/builtin/worktree.c
>> +++ b/builtin/worktree.c
>> @@ -22,7 +22,7 @@ static const char * const worktree_usage[] = {
>>    N_("git worktree move <worktree> <new-path>"),
>>    N_("git worktree prune [<options>]"),
>>    N_("git worktree remove [<options>] <worktree>"),
>> -    N_("git worktree repair [<path>]"),
>> +    N_("git worktree repair [<path>...]"),
> 
> The fact that this line was introduced in [PATCH 1/2] and then
> needed to immediately be corrected with this patch means the
> previous patch was suboptimal and this patch is "oops, the last one
> was bad and here is a band-aid fix-up".
> 
> Let's not do so.  Instead, you are encouraged to pretend to be a
> more perfect developer who does not make unnecessary mistake ;-)
> 
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 9 in “worktree: include repair cmd in usage”
  1. worktree: include repair cmd in usageDes Preston via GitGitGadget, Mar 25, 2022
  2. Eric SunshineMar 25, 2022
  3. 0/2 worktree: include repair cmd in usageDes Preston via GitGitGadget, Mar 28, 2022
  4. 2/2 worktree: accept multiple pathsDes Preston via GitGitGadget, Mar 28, 2022
  5. Junio C HamanoMar 29, 2022
  6. Desmond PrestonMar 29, 2022
  7. Junio C HamanoMar 29, 2022
  8. Eric SunshineMar 29, 2022
  9. 1/2 worktree: include repair cmd in usageDes Preston via GitGitGadget, Mar 28, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.