Re: What's cooking in git.git (Aug 2018, #04; Fri, 17)
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Aug 20, 2018, 17:44 UTC
- Message-ID
- <CAPig+cS591C+A5zTMwaYFmq+_SCvmY7RUHeDn6sRvMbqKDke-A@mail.gmail.com>
- In-Reply-To
- <7b340c01-f57d-1a71-e4d5-0346bb042d0c@talktalk.net>
On Mon, Aug 20, 2018 at 6:23 AM Phillip Wood <phillip.wood@talktalk.net> wrote:
Show 11 quoted lines
> On 17/08/2018 23:44, Junio C Hamano wrote: > > * pw/rebase-i-author-script-fix (2018-08-07) 2 commits > > - sequencer: fix quoting in write_author_script > > - sequencer: handle errors from read_author_ident() > > > > Undecided. > > Is it the list consensus to favor this "with extra code, read the > > script written by bad writer" approach? > > I think there was agreement between myself and Eric on the last version, > I'm not sure anyone else has expressed an opinion.
Phillip's v4 [1] does take backward-compatibility into account, but with minimal extra code, which seems a reasonable compromise between no backward-compatibility and the heavyweight approach of v3. I left a few comments on v4 [1], but none were blockers, and changes based upon those comments can be done later, so I think the series can move forward.
[1]: https://public-inbox.org/git/20180807093452.22524-1-phillip.wood@talktalk.net/