Re: What's cooking in git.git (Aug 2018, #04; Fri, 17)
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Aug 18, 2018, 09:34 UTC
- Message-ID
- <CAP8UFD1BOqGER4-gnv8VQfsRbZ3yYFEx-ScL3s_WfoKgV=rk6A@mail.gmail.com>
- In-Reply-To
- <xmqqva88aa0c.fsf@gitster-ct.c.googlers.com>
On Sat, Aug 18, 2018 at 12:44 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> * cc/delta-islands (2018-08-16) 7 commits
> - pack-objects: move 'layer' into 'struct packing_data'
> - pack-objects: move tree_depth into 'struct packing_data'
> - t5320: tests for delta islands
> - repack: add delta-islands support
> - pack-objects: add delta-islands support
> - pack-objects: refactor code into compute_layer_order()
> - Add delta-islands.{c,h}
>
> Lift code from GitHub to restrict delta computation so that an
> object that exists in one fork is not made into a delta against
> another object that does not appear in the same forked repository.
>
> What's the doneness of this topic?All the suggestions by Peff, you, Duy, Dscho, Ramsay and Szeder Gabor have been taken into account in the v5 that is in pu.
Except the suggestion by Duy to move 2 fields from 'struct object_entry' to 'struct packing_data' (which is implemented in patches 6/7 and 7/7) the suggestions have all been about relatively small things (documentation, code modernization, regex check, translation strings, ...) So the code is very similar to the original code in https://github.com/peff/git/commits/jk/delta-islands which has been used for years by GitHub in production.
FYI this has been requested from GitLab by Drupal (as well as others) see https://www.drupal.org/drupalorg/blog/developer-tools-initiative-part-5-gitlab-partnership which contains:
"The timeline for Phase 2 is dependent on GitLab’s resolution of a diskspace deduplication issue, which they have committed to on our behalf: https://gitlab.com/gitlab-org/gitlab-ce/issues/23029"