git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Aug 2018, #04; Fri, 17)

From
Duy Nguyen <pclouds@gmail.com>
Date
Aug 18, 2018, 06:29 UTC
Message-ID
<CACsJy8BCJSj__vmw-S0komzWyQGyFS0GjXT1fV6VCX_MLPXwHA@mail.gmail.com>
In-Reply-To
<xmqqva88aa0c.fsf@gitster-ct.c.googlers.com>
On Sat, Aug 18, 2018 at 12:44 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
> * nd/unpack-trees-with-cache-tree (2018-08-13) 5 commits
>  - unpack-trees: reuse (still valid) cache-tree from src_index
>  - unpack-trees: reduce malloc in cache-tree walk
>  - unpack-trees: optimize walking same trees with cache-tree
>  - unpack-trees: add performance tracing
>  - trace.h: support nested performance tracing
>
>  The unpack_trees() API used in checking out a branch and merging
>  walks one or more trees along with the index.  When the cache-tree
>  in the index tells us that we are walking a tree whose flattened
>  contents is known (i.e. matches a span in the index), as linearly
>  scanning a span in the index is much more efficient than having to
>  open tree objects recursively and listing their entries, the walk
>  can be optimized, which is done in this topic.
>
>  Will merge to and cook in 'next'.
Please hold.

I was going to address your "The last step feels a bit scary" comment by auditing and adding some cache-tree validation. I'm seeing some bad cache-tree when running more validation through the test suite. Maybe it's just bugs in my validation code, but better be safe than sorry.

-- 
Duy
Previous: Junio C HamanoNext: Jonathan Nieder
Message 2 of 15 in “What's cooking in git.git (Aug 2018, #04; Fri, 17)”
  1. Junio C HamanoAug 17, 2018
  2. Duy NguyenAug 18, 2018
  3. Jonathan NiederAug 18, 2018
  4. Junio C HamanoAug 20, 2018
  5. Derrick StoleeAug 20, 2018
  6. Christian CouderAug 18, 2018
  7. Ævar Arnfjörð BjarmasonAug 18, 2018
  8. Christian CouderAug 18, 2018
  9. Ævar Arnfjörð BjarmasonAug 18, 2018
  10. Phillip WoodAug 20, 2018
  11. Eric SunshineAug 20, 2018
  12. pw/rebase-i-author-script-fix, was Re: What's cooking in git.git (Aug 2018, #04; Fri, 17)Johannes Schindelin, Aug 20, 2018
  13. Stefan BellerAug 20, 2018
  14. Junio C HamanoAug 20, 2018
  15. Jonathan NiederAug 20, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.