Re: [PATCH 2/3] git-compat-util: convert string predicates to return bool

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 14, 2025, 16:46 UTC
Message-ID: <CAPig+cS=tEO90WnATueFM8FumHcq9HkPrfa_JUCzeMkDaLsYdw@mail.gmail.com>
In-Reply-To: <a0f9182aa20d0f956072a3d185a2d1288f1bd842.1752499610.git.phillip.wood@dunelm.org.uk>

On Mon, Jul 14, 2025 at 9:31 AM Phillip Wood <phillip.wood123@gmail.com> wrote:

> Since 8277dbe987 (git-compat-util: convert skip_{prefix,suffix}{,_mem}
> to bool, 2023-12-16) a number of our sting predicates have been

s/sting/string/

> returning bool instead of int. Now we've declared that experiment
> a success lets convert the return type the case independent

s/lets/let's/ /type/& of/

Show 5 quoted lines

> skip_iprefix() and skip_iprefix_mem() functions to match the return
> type of their case dependent equivalents. Returning bool instead of
> int makes it clear that these functions are predicates.
>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>