Re: [PATCH v2 0/3] C99: declare bool experiment a success

From

Elijah Newren <newren@gmail.com>

Date

Jul 15, 2025, 19:35 UTC

Message-ID

<CABPp-BHjU2NFVoM+wkBxDrr3P85yYzmS-O4mBAc_e4_6wfOBMw@mail.gmail.com>

In-Reply-To

<000001dbf5b5$8b316f00$a1944d00$@nexbridge.com>

On Tue, Jul 15, 2025 at 11:23 AM <rsbecker@nexbridge.com> wrote:

>
> On July 15, 2025 1:19 PM Elijah Newren wrote:
> >On Tue, Jul 15, 2025 at 6:53 AM Phillip Wood <phillip.wood123@gmail.com>
> >wrote:
> >>
> >> From: Phillip Wood <phillip.wood@dunelm.org.uk>
> >>
> >> We've had a test balloon for C99's bool type since 8277dbe987
> >> (git-compat-util: convert skip_{prefix,suffix}{,_mem} to bool,
> >> 2023-12-16). As it has been over 18 months since this was added and
> >> there have been no complaints let's declare it a success and convert
> >> the return type our other string predicates to match.
> >>

[...]

>
> bool is not standard in all c99 implementations. I have to #include <stdbool.h> in order to
> use this type. Please make sure there is a mechanism for that.

From the referenced commit in the commit message:

diff --git a/git-compat-util.h b/git-compat-util.h
index 3e7a59b5ff1..603c97e3b3f 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -225,6 +225,7 @@ struct strbuf;
 #include <stddef.h>
 #include <stdlib.h>
 #include <stdarg.h>
+#include <stdbool.h>
 #include <string.h>
 #ifdef HAVE_STRINGS_H
 #include <strings.h> /* for strcasecmp() */


So, there's not only a mechanism for that, it has already been done
for you 1.5 years ago.  No extra work on your or anyone else's part
needed.  :-)