Re: [PATCH v3 0/3] C99: declare bool experiment a success
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Jul 22, 2025, 08:09 UTC
- Message-ID
- <CAOLa=ZQZ_UX1YquMiJgSGN0u9+LiUAK9HijaLY5DUN1y_j6+tg@mail.gmail.com>
- In-Reply-To
- <3e799a41-fa68-4d22-8e8e-930fcab807f8@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 21 quoted lines
> Hi Karthik
>
> On 16/07/2025 11:29, Karthik Nayak wrote:
>> Phillip Wood <phillip.wood123@gmail.com> writes:
>>
>>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>>>
>>> We've had a test balloon for C99's bool type since 8277dbe987
>>> (git-compat-util: convert skip_{prefix,suffix}{,_mem} to bool,
>>> 2023-12-16). As it has been over 18 months since this was added and
>>> there have been no complaints let's declare it a success and convert
>>> the return type our other string predicates to match.
>>>
>>
>> Neat, I didn't even know we were running such an experiment. Thanks for
>> getting around to it, I think the patches look great, added some
>> complaints from 'clang-format', feel free to ignore.
>
> Thanks for taking a look. I would have fixed the formatting but this is
> in next already so I'll leave it as it is if that's ok with you.
>Of course :) These are small nits. I'm mostly interested in getting clang-format to work without any/many false positives, so I'm trying to test it with different patches that I read and report back!
> Thanks > > Phillip