git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 0/6] Move PGP verification out of verify-tag

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 19, 2016, 19:10 UTC
Message-ID
<CAPig+cRz4stVQWFD-NroVHft2xFvyZJi1ePX9T4zZ3k3=X6ZrA@mail.gmail.com>
In-Reply-To
<1461088041-19264-1-git-send-email-santiago@nyu.edu>
On Tue, Apr 19, 2016 at 1:47 PM,  <santiago@nyu.edu> wrote:
Show 14 quoted lines
> This is a follow up of [1], [2], [3], [4], [5], [6]. patches 1/6, 2/6, are the
> same as the corresponding commits in pu.
>
> v7:
> Mostly style/clarity changes mostly. Thanks Peff, Eric and Junio for the
> feedback! In summary:
>
>  * Eric pointed out issues with 3/6's commit message. It doesn't match the one
>    in pu though. I also took the opportunity to update payload_size to a size_t
>    as Peff suggested.
>  * 4/6 I updated report_name to name_to_report, I updated the commit message
>    and addressed some nits in the code, one of the fixes removed all three nits
>    that Eric pointed out. I updated 5/6 to match these changes
>  * I gave the commit message on 6/6 another go.

Thanks, this re-roll looks good. My reviews mention a couple nits, but I hope they are not worth a re-roll (perhaps Junio can address them when/if he picks up the series).

As before, the entire series is:
    Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Previous: Eric Sunshine
Message 11 of 11 in “Move PGP verification out of verify-tag”
  1. 0/6 Move PGP verification out of verify-tagsantiago@nyu.edu, Apr 19, 2016
  2. 1/6 builtin/verify-tag.c: ignore SIGPIPE in gpg-interfacesantiago@nyu.edu, Apr 19, 2016
  3. 2/6 t7030: test verifying multiple tagssantiago@nyu.edu, Apr 19, 2016
  4. 3/6 verify-tag: update variable name and typesantiago@nyu.edu, Apr 19, 2016
  5. 4/6 verify-tag: prepare verify_tag for libificationsantiago@nyu.edu, Apr 19, 2016
  6. Eric SunshineApr 19, 2016
  7. Junio C HamanoApr 19, 2016
  8. 5/6 verify-tag: move tag verification code to tag.csantiago@nyu.edu, Apr 19, 2016
  9. 6/6 tag -v: verfy directly rather than exec-ing verify-tagsantiago@nyu.edu, Apr 19, 2016
  10. Eric SunshineApr 19, 2016
  11. Eric SunshineApr 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.