Re: [PATCH v7 6/6] tag -v: verfy directly rather than exec-ing verify-tag

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 19, 2016, 19:06 UTC
Message-ID: <CAPig+cQrnrO2+hzg5nc_uBbENOn1_JH1PfHYCg-ivZVTtYRvXg@mail.gmail.com>
In-Reply-To: <1461088041-19264-7-git-send-email-santiago@nyu.edu>

On Tue, Apr 19, 2016 at 1:47 PM,  <santiago@nyu.edu> wrote:

> tag -v: verfy directly rather than exec-ing verify-tag

s/verfy/verify:

> Instead of having tag -v fork to run verify-tag, use the
> gpg_verify_tag() function directly.

This description is easy enough to understand. Thanks.

Show 19 quoted lines

> Signed-off-by: Santiago Torres <santiago@nyu.edu>
> ---
> diff --git a/builtin/tag.c b/builtin/tag.c
> index 1705c94..7b2918e 100644
> --- a/builtin/tag.c
> +++ b/builtin/tag.c
> @@ -104,13 +104,7 @@ static int delete_tag(const char *name, const char *ref,
>  static int verify_tag(const char *name, const char *ref,
>                                 const unsigned char *sha1)
>  {
> -       const char *argv_verify_tag[] = {"verify-tag",
> -                                       "-v", "SHA1_HEX", NULL};
> -       argv_verify_tag[2] = sha1_to_hex(sha1);
> -
> -       if (run_command_v_opt(argv_verify_tag, RUN_GIT_CMD))
> -               return error(_("could not verify the tag '%s'"), name);
> -       return 0;
> +       return gpg_verify_tag(sha1, name, GPG_VERIFY_VERBOSE);
>  }