From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 19 Apr 2016 19:10:00 GMT
Subject: Re: [PATCH v7 0/6] Move PGP verification out of verify-tag
Message-ID: <CAPig+cRz4stVQWFD-NroVHft2xFvyZJi1ePX9T4zZ3k3=X6ZrA@mail.gmail.com>
In-Reply-To: <1461088041-19264-1-git-send-email-santiago@nyu.edu>

On Tue, Apr 19, 2016 at 1:47 PM,  <santiago@nyu.edu> wrote:
> This is a follow up of [1], [2], [3], [4], [5], [6]. patches 1/6, 2/6, are the
> same as the corresponding commits in pu.
>
> v7:
> Mostly style/clarity changes mostly. Thanks Peff, Eric and Junio for the
> feedback! In summary:
>
>  * Eric pointed out issues with 3/6's commit message. It doesn't match the one
>    in pu though. I also took the opportunity to update payload_size to a size_t
>    as Peff suggested.
>  * 4/6 I updated report_name to name_to_report, I updated the commit message
>    and addressed some nits in the code, one of the fixes removed all three nits
>    that Eric pointed out. I updated 5/6 to match these changes
>  * I gave the commit message on 6/6 another go.

Thanks, this re-roll looks good. My reviews mention a couple nits, but
I hope they are not worth a re-roll (perhaps Junio can address them
when/if he picks up the series).

As before, the entire series is:

    Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>