Re: [PATCH 02/10] hook: fix minor style issues

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 9, 2026, 02:12 UTC
Message-ID: <CAPig+cRGJVg+qo=UZA4syvTQ58G54tHo-pSZ_6dE6pU2e0agyw@mail.gmail.com>
In-Reply-To: <20260309005416.2760030-3-adrian.ratiu@collabora.com>

On Sun, Mar 8, 2026 at 8:54 PM Adrian Ratiu <adrian.ratiu@collabora.com> wrote:

Show 12 quoted lines

> Fix some minor style nits pointed by Patrick and Junio:
>   ...
>   * Capitalization in error/warn messages.
>   ...
> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
> ---
> diff --git a/builtin/hook.c b/builtin/hook.c
> @@ -51,7 +49,7 @@ static int list(int argc, const char **argv, const char *prefix,
>         if (argc != 1)
> -               usage_msg_opt(_("You must specify a hook event name to list."),
> +               usage_msg_opt(_("you must specify a hook event name to list."),
>                               builtin_hook_list_usage, list_options);

You will also want to drop the full-stop (".") from the message according to style guidelines.