git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 16:57 UTC

[PATCH 00/10] config-hook cleanups and two small 'git hook list' features

From
Adrian Ratiu <adrian.ratiu@collabora.com>
Date
Mar 9, 2026, 00:54 UTC
Message-ID
<20260309005416.2760030-1-adrian.ratiu@collabora.com>
Hello everyone,

As promised I've spun-off v3 of the config series [1] into its own standalone patch series after v2 landed in next.

This is mostly minor cleanups and refactorings + two minor feature additions to `git hook list`, which resulted from the previous review discussions:

1. The ability to show the config scope (--show-scope).
2. The ability to show which hooks are disabled.
This is based on next because the config hooks support is only in next.
I have pushed the branch to Github [2] and provided a clean CI run [3].

Big thank-you's to all who contributed to this up to now, Adrian

1: https://lore.kernel.org/git/20260204165126.1548805-1-adrian.ratiu@collabora.com/T/#mafc63b5b32a78e48a703cccca3b7d6d9fe668fa2 2: https://github.com/10ne1/git/tree/dev/aratiu/config-cleanups-v1 3: https://github.com/10ne1/git/actions/runs/22833022192

Adrian Ratiu (10):
  hook: move unsorted_string_list_remove() to string-list.[ch]
  hook: fix minor style issues
  hook: rename cb_data_free/alloc -> hook_data_free/alloc
  hook: detect & emit two more bugs
  hook: replace hook_list_clear() -> string_list_clear_func()
  hook: make consistent use of friendly-name in docs
  t1800: add test to verify hook execution ordering
  hook: refactor hook_config_cache from strmap to named struct
  hook: show config scope in git hook list
  hook: show disabled hooks in "git hook list"
 Documentation/config/hook.adoc |  30 ++---
 Documentation/git-hook.adoc    |  15 ++-
 builtin/hook.c                 |  28 +++--
 builtin/receive-pack.c         |  11 +-
 hook.c                         | 220 +++++++++++++++++++++------------
 hook.h                         |  39 ++++--
 refs.c                         |   3 +-
 repository.h                   |   3 +-
 string-list.c                  |   9 ++
 string-list.h                  |   8 ++
 t/t1800-hook.sh                |  83 ++++++++++++-
 transport.c                    |   3 +-
 12 files changed, 321 insertions(+), 131 deletions(-)
-- 
2.52.0.732.gb351b5166d.dirty
Next: Adrian Ratiu
Message 1 of 71 in “config-hook cleanups and two small 'git hook list' features”
  1. 00/10 config-hook cleanups and two small 'git hook list' featuresAdrian Ratiu, Mar 9, 2026
  2. 01/10 hook: move unsorted_string_list_remove() to string-list.[ch]Adrian Ratiu, Mar 9, 2026
  3. 02/10 hook: fix minor style issuesAdrian Ratiu, Mar 9, 2026
  4. 03/10 hook: rename cb_data_free/alloc -> hook_data_free/allocAdrian Ratiu, Mar 9, 2026
  5. 04/10 hook: detect & emit two more bugsAdrian Ratiu, Mar 9, 2026
  6. 05/10 hook: replace hook_list_clear() -> string_list_clear_func()Adrian Ratiu, Mar 9, 2026
  7. 06/10 hook: make consistent use of friendly-name in docsAdrian Ratiu, Mar 9, 2026
  8. 08/10 hook: refactor hook_config_cache from strmap to named structAdrian Ratiu, Mar 9, 2026
  9. 07/10 t1800: add test to verify hook execution orderingAdrian Ratiu, Mar 9, 2026
  10. 09/10 hook: show config scope in git hook listAdrian Ratiu, Mar 9, 2026
  11. 10/10 hook: show disabled hooks in "git hook list"Adrian Ratiu, Mar 9, 2026
  12. Eric SunshineMar 9, 2026
  13. Eric SunshineMar 9, 2026
  14. Junio C HamanoMar 9, 2026
  15. Junio C HamanoMar 9, 2026
  16. Junio C HamanoMar 9, 2026
  17. Junio C HamanoMar 9, 2026
  18. Adrian RatiuMar 10, 2026
  19. Adrian RatiuMar 10, 2026
  20. Adrian RatiuMar 10, 2026
  21. Adrian RatiuMar 10, 2026
  22. SZEDER GáborMar 10, 2026
  23. Patrick SteinhardtMar 11, 2026
  24. Patrick SteinhardtMar 11, 2026
  25. Patrick SteinhardtMar 11, 2026
  26. Adrian RatiuMar 11, 2026
  27. Adrian RatiuMar 11, 2026
  28. Adrian RatiuMar 11, 2026
  29. Adrian RatiuMar 11, 2026
  30. Patrick SteinhardtMar 11, 2026
  31. 00/10 config-hook cleanups and two small 'git hook list' featuresAdrian Ratiu, Mar 20, 2026
  32. 01/10 hook: move unsorted_string_list_remove() to string-list.[ch]Adrian Ratiu, Mar 20, 2026
  33. 03/10 hook: rename cb_data_free/alloc -> hook_data_free/allocAdrian Ratiu, Mar 20, 2026
  34. 04/10 hook: detect & emit two more bugsAdrian Ratiu, Mar 20, 2026
  35. 05/10 hook: replace hook_list_clear() -> string_list_clear_func()Adrian Ratiu, Mar 20, 2026
  36. 06/10 hook: make consistent use of friendly-name in docsAdrian Ratiu, Mar 20, 2026
  37. 07/10 t1800: add test to verify hook execution orderingAdrian Ratiu, Mar 20, 2026
  38. 08/10 hook: introduce hook_config_cache_entry for per-hook dataAdrian Ratiu, Mar 20, 2026
  39. 02/10 hook: fix minor style issuesAdrian Ratiu, Mar 20, 2026
  40. 09/10 hook: show config scope in git hook listAdrian Ratiu, Mar 20, 2026
  41. 10/10 hook: show disabled hooks in "git hook list"Adrian Ratiu, Mar 20, 2026
  42. Junio C HamanoMar 23, 2026
  43. Patrick SteinhardtMar 24, 2026
  44. Patrick SteinhardtMar 24, 2026
  45. Patrick SteinhardtMar 24, 2026
  46. Patrick SteinhardtMar 24, 2026
  47. Patrick SteinhardtMar 24, 2026
  48. Junio C HamanoMar 24, 2026
  49. Adrian RatiuMar 24, 2026
  50. Adrian RatiuMar 24, 2026
  51. Adrian RatiuMar 24, 2026
  52. Adrian RatiuMar 24, 2026
  53. Patrick SteinhardtMar 25, 2026
  54. Adrian RatiuMar 25, 2026
  55. 00/12 config-hook cleanups and three small git-hook featuresAdrian Ratiu, Mar 25, 2026
  56. 01/12 hook: move unsorted_string_list_remove() to string-list.[ch]Adrian Ratiu, Mar 25, 2026
  57. 02/12 builtin/receive-pack: properly init receive_hook strbufAdrian Ratiu, Mar 25, 2026
  58. 04/12 hook: rename cb_data_free/alloc -> hook_data_free/allocAdrian Ratiu, Mar 25, 2026
  59. 03/12 hook: fix minor style issuesAdrian Ratiu, Mar 25, 2026
  60. 05/12 hook: detect & emit two more bugsAdrian Ratiu, Mar 25, 2026
  61. 06/12 hook: replace hook_list_clear() -> string_list_clear_func()Adrian Ratiu, Mar 25, 2026
  62. 07/12 hook: make consistent use of friendly-name in docsAdrian Ratiu, Mar 25, 2026
  63. 08/12 t1800: add test to verify hook execution orderingAdrian Ratiu, Mar 25, 2026
  64. 09/12 hook: introduce hook_config_cache_entry for per-hook dataAdrian Ratiu, Mar 25, 2026
  65. 10/12 hook: show config scope in git hook listAdrian Ratiu, Mar 25, 2026
  66. 11/12 hook: show disabled hooks in "git hook list"Adrian Ratiu, Mar 25, 2026
  67. 12/12 hook: reject unknown hook names in git-hook(1)Adrian Ratiu, Mar 25, 2026
  68. Junio C HamanoMar 25, 2026
  69. Adrian RatiuMar 26, 2026
  70. Patrick SteinhardtMar 27, 2026
  71. Junio C HamanoMar 27, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.