[PATCH v2 04/10] hook: detect & emit two more bugs

From

Adrian Ratiu <adrian.ratiu@collabora.com>

Date

Mar 20, 2026, 11:52 UTC

Message-ID

<20260320115211.177351-5-adrian.ratiu@collabora.com>

In-Reply-To

<20260320115211.177351-1-adrian.ratiu@collabora.com>

Also issue a bug if a configured hook is enabled without a cmd.

Mostly useful for defensive coding.

Suggested-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
---
 hook.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hook.c b/hook.c
index afa8db21a0..6dfaa7e9b1 100644
--- a/hook.c
+++ b/hook.c
@@ -408,7 +408,11 @@ static int pick_next_hook(struct child_process *cp,
 	} else if (h->kind == HOOK_CONFIGURED) {
 		/* to enable oneliners, let config-specified hooks run in shell. */
 		cp->use_shell = true;
+		if (!h->u.configured.command)
+			BUG("non-disabled HOOK_CONFIGURED hook has no command");
 		strvec_push(&cp->args, h->u.configured.command);
+	} else {
+		BUG("unknown hook kind");
 	}
 
 	if (!cp->args.nr)

-- 
2.52.0.732.gb351b5166d.dirty