Re: [PATCH] chainlint: colorize problem annotations and test delimiters
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Sep 13, 2022, 00:39 UTC
- Message-ID
- <CAPig+cR4neH_FU+tTr3qzyPp=5WJUfFydw7Y4CMJn4k+iSQs6A@mail.gmail.com>
- In-Reply-To
- <xmqqo7vkazuh.fsf@gitster.g>
On Mon, Sep 12, 2022 at 8:21 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes: > > (2) In practice, I found that even after coloring those annotations in > > red, it was still easy for the eye to glide right over them in the > > output without really noticing them. Switching it to bold red helped a > > bit, but my eye still glided over them sometimes. One possible reason > > that the eye was able to glide over them may be because the "?!FOO?!" > > annotations are very short bits of text buried in the much larger and > > textually noisy test body. > > Maybe partly because I work with black-ink-on-white-paper terminal > setting, and maybe partly because my color perception is suboptimal, > I learned to use "[diff.color] old = red reverse", because non-bold > red letters do not stand out enough. Perhaps you may want to try > reverse output to see how well it makes them stand out for you.
Hmm, yes, that might be worth investigating. I also typically work with black-ink-on-white-paper terminal, and although the problem is perhaps worse with that color scheme, I nevertheless found that my eye would sometimes glide over the red annotations even when I tested with other color schemes (i.e. light-ink-on-dark-paper).