From: Eric Sunshine Date: Tue, 13 Sep 2022 00:39:27 GMT Subject: Re: [PATCH] chainlint: colorize problem annotations and test delimiters Message-ID: In-Reply-To: On Mon, Sep 12, 2022 at 8:21 PM Junio C Hamano wrote: > Eric Sunshine writes: > > (2) In practice, I found that even after coloring those annotations in > > red, it was still easy for the eye to glide right over them in the > > output without really noticing them. Switching it to bold red helped a > > bit, but my eye still glided over them sometimes. One possible reason > > that the eye was able to glide over them may be because the "?!FOO?!" > > annotations are very short bits of text buried in the much larger and > > textually noisy test body. > > Maybe partly because I work with black-ink-on-white-paper terminal > setting, and maybe partly because my color perception is suboptimal, > I learned to use "[diff.color] old = red reverse", because non-bold > red letters do not stand out enough. Perhaps you may want to try > reverse output to see how well it makes them stand out for you. Hmm, yes, that might be worth investigating. I also typically work with black-ink-on-white-paper terminal, and although the problem is perhaps worse with that color scheme, I nevertheless found that my eye would sometimes glide over the red annotations even when I tested with other color schemes (i.e. light-ink-on-dark-paper).