Re: [PATCH v2] chainlint: colorize problem annotations and test delimiters
- From
Jeff King <peff@peff.net>
- Date
- Sep 13, 2022, 20:40 UTC
- Message-ID
- <YyDqycOlUYJO3332@coredump.intra.peff.net>
- In-Reply-To
- <pull.1324.v2.git.git.1663041707260.gitgitgadget@gmail.com>
On Tue, Sep 13, 2022 at 04:01:47AM +0000, Eric Sunshine via GitGitGadget wrote:
> Reverse video certainly makes the "?!FOO?!" annotations pop out and draw > the reader's attention. I find that I don't have a strong preference > between this version and v1 which merely used bold-red, but I suspect > that v2 with its reverse video is probably the better approach.
I find this one slightly uglier, but they are equally attention-grabbing. And as I hope to rarely see them in the first place, I am fine either way. :)
Thanks again for adding this.
-Peff