Re: [PATCH] chainlint: colorize problem annotations and test delimiters

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 13, 2022, 00:21 UTC
Message-ID: <xmqqo7vkazuh.fsf@gitster.g>
In-Reply-To: <CAPig+cTq3j5M7cz3T14h9U6e+H5PAu8JJ_Svq87W3WviwS6_qA@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 7 quoted lines

> (2) In practice, I found that even after coloring those annotations in
> red, it was still easy for the eye to glide right over them in the
> output without really noticing them. Switching it to bold red helped a
> bit, but my eye still glided over them sometimes. One possible reason
> that the eye was able to glide over them may be because the "?!FOO?!"
> annotations are very short bits of text buried in the much larger and
> textually noisy test body.

Maybe partly because I work with black-ink-on-white-paper terminal setting, and maybe partly because my color perception is suboptimal, I learned to use "[diff.color] old = red reverse", because non-bold red letters do not stand out enough. Perhaps you may want to try reverse output to see how well it makes them stand out for you.

I do not think if configurability like "git diff" has is necessary; it would be overkill. I personally do not mind more noise "?!" around the keyword, especially since these are only shown when there are problems detected.