Re: [PATCH 54/68] drop strcpy in favor of raw sha1_to_hex

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 24, 2015, 23:42 UTC
Message-ID: <CAPig+cQSOoYwG7EKDWPWoB+vHvYWv6ZHg9Zhd8bvH6XKfmG_1w@mail.gmail.com>
In-Reply-To: <20150924210805.GY30946@sigill.intra.peff.net>

On Thu, Sep 24, 2015 at 5:08 PM, Jeff King <peff@peff.net> wrote:

Show 9 quoted lines

> In some cases where we strcpy() the result of sha1_to_hex(),
> there's no need; the result goes directly into a printf
> statement, and we can simply pass the return value from
> sha1_to_hex() directly.
>
> When this code was originally written, sha1_to_hex used a
> single buffer, and it was not safe to use it twice within a
> single expression. That changed as of dcb3450 (sha1_to_hex()
> usage cleanup, 2006-05-03), but this code ewas never

s/ewas/was/

> updated.
>
> History-dug-by: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Jeff King <peff@peff.net>

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.