Re: [PATCH 41/68] init: use strbufs to store paths

From: Jeff King <peff@peff.net>
Date: Oct 1, 2015, 02:51 UTC
Message-ID: <20151001025119.GA31565@sigill.intra.peff.net>
In-Reply-To: <xmqqh9mb7k3r.fsf@gitster.mtv.corp.google.com>

On Wed, Sep 30, 2015 at 01:00:56PM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> > Wow, my patch isn't even close to reasonable. I didn't realize because
> > we do not compile this code at all for non-Mac platforms. Sorry.
> 
> Perhaps the way we completely stub out the platform specific helpers
> contributes to this kind of gotchas?  I am wondering how much additional
> safety we would gain if we start doing something like this.

I think it is an improvement, but it does not solve all of the problems. I also botched the implementation of probe_utf8_pathname_composition, and that does not get compiled on most platforms (though we _could_ compile it and just never call it).

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.