Re: [PATCH 60/68] prefer memcpy to strcpy
- From
Rasmus Villemoes <rv@rasmusvillemoes.dk>
- Date
- Sep 28, 2015, 07:09 UTC
- Message-ID
- <87fv1zf29x.fsf@rasmusvillemoes.dk>
- In-Reply-To
- <20150924210818.GE30946@sigill.intra.peff.net>
On Thu, Sep 24 2015, Jeff King <peff@peff.net> wrote:
> This also eliminates calls to strcpy, which make auditing > the code base harder.
Maybe may English parser is broken, but this doesn't immediately sound like what you meant to say. Also, in 29/68 you say "We drop calls to strcpy, which makes auditing the code base easier." Maybe it's all ok, since on second reading the first "make" probably refers to the plural "calls for strcpy", while in the second case "makes" refers to "[the dropping of] calls to strcpy".
Rasmus