Re: [PATCH 41/68] init: use strbufs to store paths

From: Jeff King <peff@peff.net>
Date: Oct 4, 2015, 03:37 UTC
Message-ID: <20151004033713.GB20876@sigill.intra.peff.net>
In-Reply-To: <561044AD.8010803@web.de>

On Sat, Oct 03, 2015 at 11:12:13PM +0200, Torsten Bögershausen wrote:

Show 9 quoted lines

> > Hmph, Peff's quick-fix passed the original "CoNfIg" in &buf directly
> > to probe_utf8_pathname_composition() without changing its signature.
> True, ( I was thinking that the test did only work on case insensitive FS).
> We can skip that change.
> 
> Beside that, I later realized, that a better signature could be:
> +void probe_utf8_pathname_composition(const char *path, size_t len)
> 
> I can send a proper patch the next days.

That is the original signature, before my sprintf series. I do not mind leaving that as-is, and simply cleaning up probe_utf8_pathname_composition by using a strbuf internally there. Though I have to wonder if it even needs us to pass _anything_ at that point. It could just call git_path_buf("config%s", auml_nfd) itself. The whole reason to pass anything was to let it reuse the buffer the caller had.

-Peff