Re: [PATCH] apply: mark some file-local symbols static

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 2, 2016, 22:44 UTC
Message-ID: <CAPc5daVo2o7zxTGVARoZc8AmX2WAJC1cWB4R=9sG8TH8ddKkuA@mail.gmail.com>
In-Reply-To: <a2b34209-2244-d498-6ed2-4f9fbf9f7ed1@ramsayjones.plus.com>

On Tue, Aug 2, 2016 at 3:33 PM, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 16 quoted lines

>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Christian,
>
> I had intended to ask you to squash this into your 'cc/apply-am'
> branch, specifically commit 4d18b33a (apply: move libified code
> from builtin/apply.c to apply.{c,h}, 30-07-2016).
>
> However, having read that commit a little closer, it seems that
> you deliberately made these symbols public. The commit message
> does not mention this issue at all, and it is not clear to me
> why these symbols should be public.
>
> What am I missing?

Their exports have been made obsolete by the reroll we have in 'pu' when "builtin/am: use apply api in run_apply()" was redone in a way not to duplicate the argument parsing.

They should have been cleaned with 4820e13, but I think Christian did not carefully review the whole series before sending it out and did not notice that they no longer need to be extern.