Re: [PATCH] apply: mark some file-local symbols static

From: Christian Couder <christian.couder@gmail.com>
Date: Aug 7, 2016, 16:37 UTC
Message-ID: <CAP8UFD3MN0-Eq+BRrJaFBWX7YjgVPiEmPMU=BL0K_FVtaZppTw@mail.gmail.com>
In-Reply-To: <alpine.DEB.2.20.1608031635570.107993@virtualbox>

Hi Dscho,

On Wed, Aug 3, 2016 at 4:37 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 17 quoted lines

> Hi Christian,
>
> On Wed, 3 Aug 2016, Christian Couder wrote:
>
>> Now there are different options to fix this:
>>
>> 1) remove the symbols in 9f87c22 ("apply: refactor `git apply` option
>> parsing") at the end of the series, or
>> 2) move 4820e13 (apply: make some parsing functions static again) at
>> the end of the series and make it also remove them, or:
>> 3) add another patch to remove them after 9f87c22 ("apply: refactor
>> `git apply` option parsing")
>
> You forgot 4) provide fixup patches that fix the patch series.
>
> And 5) fix the patch series, push the branch to GitHub and provide a
> pointer, but not sending a new iteration unless needed otherwise.

Unfortunately there are other changes, especially those suggested by Peff, I have to make in the patch series, so I will resend everything.

Thanks, Christian.