From: Junio C Hamano Date: Tue, 02 Aug 2016 22:44:45 GMT Subject: Re: [PATCH] apply: mark some file-local symbols static Message-ID: In-Reply-To: On Tue, Aug 2, 2016 at 3:33 PM, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones > --- > > Hi Christian, > > I had intended to ask you to squash this into your 'cc/apply-am' > branch, specifically commit 4d18b33a (apply: move libified code > from builtin/apply.c to apply.{c,h}, 30-07-2016). > > However, having read that commit a little closer, it seems that > you deliberately made these symbols public. The commit message > does not mention this issue at all, and it is not clear to me > why these symbols should be public. > > What am I missing? Their exports have been made obsolete by the reroll we have in 'pu' when "builtin/am: use apply api in run_apply()" was redone in a way not to duplicate the argument parsing. They should have been cleaned with 4820e13, but I think Christian did not carefully review the whole series before sending it out and did not notice that they no longer need to be extern.