git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] apply: mark some file-local symbols static

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 3, 2016, 14:37 UTC
Message-ID
<alpine.DEB.2.20.1608031635570.107993@virtualbox>
In-Reply-To
<CAP8UFD2NFZCAF=ZWNf4YF+F2L7A4ZM0XS98o-cR_MjuLLR8pfg@mail.gmail.com>
Hi Christian,
On Wed, 3 Aug 2016, Christian Couder wrote:
Show 8 quoted lines
> Now there are different options to fix this:
> 
> 1) remove the symbols in 9f87c22 ("apply: refactor `git apply` option
> parsing") at the end of the series, or
> 2) move 4820e13 (apply: make some parsing functions static again) at
> the end of the series and make it also remove them, or:
> 3) add another patch to remove them after 9f87c22 ("apply: refactor
> `git apply` option parsing")
You forgot 4) provide fixup patches that fix the patch series.

And 5) fix the patch series, push the branch to GitHub and provide a pointer, but not sending a new iteration unless needed otherwise.

Ciao, Johannes

Previous: Ramsay JonesNext: Christian Couder
Message 5 of 6 in “apply: mark some file-local symbols static”
  1. apply: mark some file-local symbols staticRamsay Jones, Aug 2, 2016
  2. Junio C HamanoAug 2, 2016
  3. Christian CouderAug 3, 2016
  4. Ramsay JonesAug 3, 2016
  5. Johannes SchindelinAug 3, 2016
  6. Christian CouderAug 7, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.