Re: [RFC/PATCH] verify-tag: add --check-name flag

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 7, 2016, 22:35 UTC
Message-ID: <CAPc5daV9ZvHqFtdzr565vp6Mv7O66ySr-p5Vi8o6bd6=GyVELg@mail.gmail.com>
In-Reply-To: <20160607222908.GA25631@sigill.intra.peff.net>

On Tue, Jun 7, 2016 at 3:29 PM, Jeff King <peff@peff.net> wrote:

Show 7 quoted lines

> or even:
>
>   git tag --show-tag-name foo/v1.0
>
> when refs/remotes/foo/v1.0 exists?
>
> The rule right now is generally that "git tag" takes actual tag names.

Ahh, I forgot about that. Yes, indeed the command does not work like other Git commands, which would just let generic revision parser to accept an object name from anywhere. Probably it was a mistake, because "git tag --verify $T" may find refs/tags/$T but that may not necessarily mean "git checkout $T^0" would give you that exact tree state, but it is too late to change now.

So yes, I agree with you that any validation-related thing needs to start from names relative to refs/tags/, not from object names, to be consistent.

Which is a bit sad, but I do not offhand think of a way to avoid it.