Re: [RFC/PATCH] verify-tag: add --check-name flag

From: Jeff King <peff@peff.net>
Date: Jun 7, 2016, 21:08 UTC
Message-ID: <20160607210856.GA6807@sigill.intra.peff.net>
In-Reply-To: <20160607195608.16643-1-santiago@nyu.edu>

On Tue, Jun 07, 2016 at 03:56:08PM -0400, santiago@nyu.edu wrote:

Show 15 quoted lines

> diff --git a/tag.c b/tag.c
> index d1dcd18..591b31e 100644
> --- a/tag.c
> +++ b/tag.c
> @@ -55,6 +55,14 @@ int gpg_verify_tag(const unsigned char *sha1, const char *name_to_report,
>  
>  	ret = run_gpg_verify(buf, size, flags);
>  
> +	if (flags & TAG_VERIFY_NAME) {
> +		struct tag tag_info;
> +		ret += parse_tag_buffer(&tag_info, buf, size);
> +		if strncmp(tag_info.tag, name_to_report, size)
> +			ret += error("tag name doesn't match tag header!(%s)",
> +					tag_info.tag);
> +	}

Er, is this C? :)

I think the general idea of an option to check the tag-name is a good one. But there are some corner cases to think about:

  1. What name are we comparing against? Presumably it comes from the
     name the user gave us that resolved to the tag object. We would
     want to shorten "refs/tags/v1.4" to just "v1.4", I would think.

     Would a user ever want to pass a different tagname?

  2. What do we do for non-annotated tags? Is it always a failure?

-Peff