Re: [RFC/PATCH] verify-tag: add --check-name flag

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 7, 2016, 22:11 UTC
Message-ID: <CAPc5daV=gqDLeFLB2csJDvNo4fpSKW_FjoB10TyroapQiHFq=A@mail.gmail.com>
In-Reply-To: <20160607220743.GA21043@sigill.intra.peff.net>

On Tue, Jun 7, 2016 at 3:07 PM, Jeff King <peff@peff.net> wrote:

Show 7 quoted lines

>>
>> Puzzled.  I didn't even use --format=%(tagname) in the above.
>
> No, but you used --show-tagname, which does not exist today (and which
> IMHO should be implemented as --format). Would --show-tagname take
> either a tagname _or_ a sha1? I assume it would not be calling
> get_sha1(), as having it find refs/heads/$tag would be silly.

And you do not even want to rely on where refs/tags/* it lives. show-tagname, as I hinted in the first response, was meant to be a short-hand for

       git cat-file tag $tag_object_name | sed -e '/^$/q' -e 's/^tag //p'

so I am still puzzled.