Re: [RFC/PATCH] verify-tag: add --check-name flag
- From
Jeff King <peff@peff.net>
- Date
- Jun 7, 2016, 22:13 UTC
- Message-ID
- <20160607221325.GA21166@sigill.intra.peff.net>
- In-Reply-To
- <CAPc5daV=gqDLeFLB2csJDvNo4fpSKW_FjoB10TyroapQiHFq=A@mail.gmail.com>
On Tue, Jun 07, 2016 at 03:11:47PM -0700, Junio C Hamano wrote:
Show 16 quoted lines
> On Tue, Jun 7, 2016 at 3:07 PM, Jeff King <peff@peff.net> wrote: > >> > >> Puzzled. I didn't even use --format=%(tagname) in the above. > > > > No, but you used --show-tagname, which does not exist today (and which > > IMHO should be implemented as --format). Would --show-tagname take > > either a tagname _or_ a sha1? I assume it would not be calling > > get_sha1(), as having it find refs/heads/$tag would be silly. > > And you do not even want to rely on where refs/tags/* it lives. > show-tagname, as I hinted in the first response, was meant to be > a short-hand for > > git cat-file tag $tag_object_name | sed -e '/^$/q' -e 's/^tag //p' > > so I am still puzzled.
If you are suggesting that you can do the whole thing today by parsing the tag object yourself, then sure, I agree. I thought the point of the exercise was to make that less painful for the callers.
-Peff