Re: [PATCH 2/2] config.mak.dev: alternative workaround to gcc 12 warning in http.c

From: Carlo Arenas <carenas@gmail.com>
Date: Apr 16, 2022, 00:02 UTC
Message-ID: <CAPUEspj4zu-59qxoVPMDGwMvWmu977WRDe7=t0if7raz=H24AQ@mail.gmail.com>
In-Reply-To: <xmqqh76taplg.fsf@gitster.g>

On Fri, Apr 15, 2022 at 4:34 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> diff --git c/http.c w/http.c
> index 229da4d148..85437b1980 100644
> --- c/http.c
> +++ w/http.c
> @@ -1367,6 +1367,9 @@ void run_active_slot(struct active_request_slot *slot)
>                         select(max_fd+1, &readfds, &writefds, &excfds, &select_timeout);
>                 }
>         }
> +
> +       if (slot->finished == &finished)
> +               slot->finished = NULL;
>  }
>
>  static void release_active_slot(struct active_request_slot *slot)

this would be IMHO a better fix than the one currently queued in ab/http-gcc-12-workaround and indeed squashes the warning with the gcc 12 version that is likely to be released with Fedora 36, but notice that it was proposed before[1] and apparently didn't work with the version of the compiler that Ævar was using at that time, as documented in the commit message.

Either way, my hope is (assuming this series will go earlier than the other one), that a revert to this commit is included at the end of ab/http-gcc-12-workaround, instead of adding any code changes to this series.

Carlo

[1] https://lore.kernel.org/git/xmqq8rv2nggn.fsf@gitster.g/