Re: [PATCH] ci: lock "pedantic" job into fedora 35 and other cleanup
- From
Carlo Arenas <carenas@gmail.com>
- Date
- Apr 15, 2022, 21:03 UTC
- Message-ID
- <CAPUEspgsfn71JEM5mdG2u9vO6YgEhvdZqtixW9kVyOetqz8RWQ@mail.gmail.com>
- In-Reply-To
- <xmqqwnfqci6f.fsf@gitster.g>
On Fri, Apr 15, 2022 at 11:31 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> > Carlo Marcelo Arenas Belón <carenas@gmail.com> writes: > > > Fedora 36 is scheduled to be released in Apr 19th, but it includes > > a prerelease of gcc 12 that has known issues[1] with our codebase > > and therefore requires extra changes to not break a DEVELOPER=1 > > build. > > > > Lock the CI job to the current release image, and while at it rename > > the job to better reflect what it is currently doing, instead of its > > original objective. > > Please spell out what "original objective" is, why we are changing > the purpose of the target, and how such a change is justifiable.
Will do in a reroll with the objective of "let's make the pedantic job more useful" but that is IMHO less of a priority and orthogonal to the objective of this series which was "let's avoid breaking our CI because of fedora's gcc updates".
Original I had that done on top of ab/http-gcc-12-workaround (which fixes a real, albeit likely harmless bug that compiler was surfacing, and that will also break our CI in a few days) but after the feedback from this thread, think might be preferred and also less likely to conflict with current seen.
Would that be reasonable, eventhough it is so late in the RC cycle?
Carlo